Skip to content

DOC: Fix PEP-8 issues in computation.rst and comparison_*.rst #24002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2018

Conversation

FHaase
Copy link
Contributor

@FHaase FHaase commented Nov 29, 2018

  • Fix PEP-8 issues in comparison_*.rst
  • Fix PEP-8 issues in computation.rst

Signed-off-by: Fabian Haase <haase.fabian@gmail.com>
Signed-off-by: Fabian Haase <haase.fabian@gmail.com>
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fixes @FHaase

Can you just take a look at the CI? not sure why it's red

@datapythonista datapythonista added Docs Code Style Code style, linting, code_checks labels Nov 29, 2018
@FHaase
Copy link
Contributor Author

FHaase commented Nov 30, 2018

Both unrelated.

CircleCi: Hypothesis test timed out.

=================================== FAILURES ===================================
___________________________ test_tick_add_sub[Micro] ___________________________

cls = <class 'pandas.tseries.offsets.Micro'>

    @pytest.mark.parametrize('cls', tick_classes)
>   @example(n=2, m=3)
    @example(n=800, m=300)
    @example(n=1000, m=5)
    @given(n=st.integers(-999, 999), m=st.integers(-999, 999))
    def test_tick_add_sub(cls, n, m):

pandas/tests/tseries/offsets/test_ticks.py:41: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/opt/conda/envs/pandas-dev/lib/python3.6/site-packages/hypothesis/core.py:552: in execute
    ) % (test.__name__, text_repr[0],))
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <hypothesis.core.StateForActualGivenExecution object at 0x7f7503574c50>
message = 'Hypothesis test_tick_add_sub(cls=Micro, n=-138, m=721) produces unreliable results: Falsified on the first call but did not on a subsequent one'

    def __flaky(self, message):
        if len(self.falsifying_examples) <= 1:
>           raise Flaky(message)
E           hypothesis.errors.Flaky: Hypothesis test_tick_add_sub(cls=Micro, n=-138, m=721) produces unreliable results: Falsified on the first call but did not on a subsequent one

/opt/conda/envs/pandas-dev/lib/python3.6/site-packages/hypothesis/core.py:727: Flaky
---------------------------------- Hypothesis ----------------------------------
Falsifying example: test_tick_add_sub(cls=Micro, n=-138, m=721)
Unreliable test timings! On an initial run, this test took 1058.10ms, which exceeded the deadline of 500.00ms, but on a subsequent run it took 0.08 ms, which did not. If you expect this sort of variability in your test timings, consider turning deadlines off for this test by setting deadline=None.

Azure: Downloading unsuccessful.

2018-11-29T22:55:51.8190144Z At D:\a\_temp\44684352-d085-41e0-85fc-7478797d5ded.ps1:3 char:1
2018-11-29T22:55:51.8190207Z + $wc.Downloadfile("https://download.microsoft.com/download/7/9/6/796EF ...
2018-11-29T22:55:51.8190284Z + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2018-11-29T22:55:51.8190343Z     + CategoryInfo          : NotSpecified: (:) [], ParentContainsErrorRecordException
2018-11-29T22:55:51.8191084Z     + FullyQualifiedErrorId : WebException

@datapythonista
Copy link
Member

do you mind merging master and pushing, so the CI reruns then?

@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #24002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24002   +/-   ##
=======================================
  Coverage   42.46%   42.46%           
=======================================
  Files         161      161           
  Lines       51557    51557           
=======================================
  Hits        21892    21892           
  Misses      29665    29665
Flag Coverage Δ
#single 42.46% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45eb26...4c09acf. Read the comment docs.

@datapythonista datapythonista changed the title DOC: Fix PEP-8 issues DOC: Fix PEP-8 issues in computation.rst and comparison_*.rst Nov 30, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 2, 2018
@jreback jreback merged commit e303a46 into pandas-dev:master Dec 2, 2018
@jreback
Copy link
Contributor

jreback commented Dec 2, 2018

thanks @FHaase

@FHaase FHaase deleted the fix-pep8 branch December 3, 2018 19:10
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants